Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support List[List[byte, N], N] #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kasey
Copy link
Collaborator

@kasey kasey commented May 5, 2023

Current spectests generated by the methodical repo were not covering ExecutionPayload, so I missed that nested lists were not supported. This commit adds support for List[List[byte, N], N]. 2 things should happen before I remove WIP from the title:

  • Cover List[List] via prysm's ExecutionPayload type in spectests.
  • double check test coverage of geth's uin256 type and any other types they are currently developing with methodical. Ideally add some additional test fixtures to cover patterns from the existing types.

This PR also has a commit removing all the values/funcs/types flagged by the golangci-lint deadcode checker. There are only 2 commits so it may be easiest to review this PR one commit at a time. I am also happy to split off the lint commit into a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant