Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for beacon auth header #2162

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add option for beacon auth header #2162

merged 1 commit into from
Feb 28, 2024

Conversation

Tristan-Wilson
Copy link
Member

Testing done

Add a dummy value to the auth header in nodeconfig:

{
  "parent-chain": {
          "blob-client": {
                  "beacon-url": "http://localhost:3509",
                  "authorization": "Basic asdf"
          },
...

Run netcat to intercept beacon chain requests, check that the header is there:

$ nc -l -p 3509
GET /eth/v1/beacon/genesis HTTP/1.1
Host: localhost:3509
User-Agent: Go-http-client/1.1
Authorization: Basic asdf
Accept-Encoding: gzip

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Feb 28, 2024
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson
Copy link
Member Author

Fixes #2159

@PlasmaPower PlasmaPower merged commit b6ef4d0 into master Feb 28, 2024
8 checks passed
@PlasmaPower PlasmaPower deleted the beacon-auth-header branch February 28, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants