Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Blob data as fetched from beaconURL to disk #2166

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Save Blob data as fetched from beaconURL to disk #2166

merged 2 commits into from
Mar 1, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Mar 1, 2024
@Tristan-Wilson
Copy link
Member

I confirmed what we're saving to disk matches field-by-field with what is coming from upstream

$ curl $CL/eth/v1/beacon/blob_sidecars/4458202 |jq -S . > ../data/3/blobs/4458202.raw.pretty
$ cat ../../4/blobs/4458202 | jq -S . > 4458202.new.pretty
$ diff 4458202.new.pretty 4458202.raw.pretty

@ganeshvanahalli ganeshvanahalli merged commit 60ff801 into master Mar 1, 2024
8 checks passed
@ganeshvanahalli ganeshvanahalli deleted the update-saveblobtodisk-design branch March 1, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-Wilson Tristan-Wilson Tristan-Wilson approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshvanahalli @Tristan-Wilson