Support blob transactions in data poster external signer #2169
Conversation
cla-bot
bot
added
the
s
anodar
changed the title
|
|
||
| type SignTxArgs struct { | ||
| *apitypes.SendTxArgs |
There was a problem hiding this comment.
I was looking to see why the blob fields weren't on apitypes.SendTxArgs already, and looking at the comments on apitypes.SendTxArgs it says
// This struct is identical to ethapi.TransactionArgs, except for the usage of
// common.MixedcaseAddress in From and To
but the fields haven't been copied over yet from ethapi.TransactionArgs. This looks like a typical case of code that's supposed to be kept in sync manually being overlooked. For the time being, in ethapi.TransactionArgs the fields actually have different types than the types you specified here, so until it's fixed upstream we should probably use the types they already picked.
There was a problem hiding this comment.
I raised ethereum/go-ethereum#29161 with upstream to see if this is just an oversight or something more.
There was a problem hiding this comment.
Makes sense, changed to follow types of fields in ethapi.TransactionArgs struct.
No description provided.