Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up retryable escrow accounts in ArbOS 30 [NIT-2453] #2257

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Clean up retryable escrow accounts in ArbOS 30 [NIT-2453] #2257

merged 2 commits into from
Apr 30, 2024

Conversation

PlasmaPower
Copy link
Collaborator

No description provided.

@PlasmaPower PlasmaPower requested a review from tsahee April 24, 2024 20:58
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 24, 2024
@PlasmaPower PlasmaPower changed the title Clean up retryable escrow accounts in ArbOS 30 Clean up retryable escrow accounts in ArbOS 30 [NIT-2453] Apr 24, 2024
joshuacolvin0
joshuacolvin0 previously approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower requested review from magicxyyz and removed request for tsahee April 29, 2024 16:05
magicxyyz
magicxyyz previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicxyyz
Copy link
Contributor

a note: as we have ArbOS 30 now, we can probably add an ArbOS 20->30 upgrade test (not necessarily in this PR, just bumping it up):

nitro/system_tests/precompile_test.go

Lines 163 to 164 in 112f1d3

// TODO: Once we have an ArbOS 30, test a real upgrade with it
// We can't test 11 -> 20 because 11 doesn't have the GetScheduledUpgrade method we want to test

@PlasmaPower
Copy link
Collaborator Author

I've addressed the merge conflicts. The ArbOS 30 test in this PR should double as an upgrade test, because when initializing ArbOS we run the upgrade code for each past version.

magicxyyz
magicxyyz approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit e6afd28 into master Apr 30, 2024
8 checks passed
@PlasmaPower PlasmaPower deleted the arbos-30-cleanup-escrow branch April 30, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicxyyz magicxyyz magicxyyz approved these changes

@joshuacolvin0 joshuacolvin0 joshuacolvin0 left review comments

Assignees
No one assigned
Labels
consensus s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PlasmaPower @magicxyyz @joshuacolvin0