Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-1264] V0 Snap Sync #2265

Merged
merged 35 commits into from
Jun 4, 2024
Merged

[NIT-1264] V0 Snap Sync #2265

merged 35 commits into from
Jun 4, 2024

Conversation

amsanghi
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 30, 2024
@amsanghi amsanghi marked this pull request as ready for review May 2, 2024 14:24
@amsanghi amsanghi changed the title V0 Snap Sync [NIT-1264] V0 Snap Sync May 2, 2024
@amsanghi amsanghi requested a review from tsahee May 2, 2024 14:24
tsahee
tsahee requested changes May 7, 2024
View reviewed changes
arbnode/node.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee May 7, 2024 12:53
tsahee
tsahee reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer

system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
arbnode/node.go Outdated Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee May 9, 2024 15:57
tsahee
tsahee reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_reader.go Show resolved Hide resolved
arbnode/node.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee May 15, 2024 04:23
tsahee
tsahee reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close. Sorry for the long delay.

arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
arbnode/inbox_tracker.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Show resolved Hide resolved
tsahee
tsahee reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comments for the test remain

system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Show resolved Hide resolved
system_tests/snap_sync_test.go Outdated Show resolved Hide resolved
system_tests/snap_sync_test.go Show resolved Hide resolved
@amsanghi amsanghi requested a review from tsahee June 3, 2024 15:12
@tsahee tsahee enabled auto-merge June 3, 2024 22:16
@tsahee tsahee merged commit 37a3132 into master Jun 4, 2024
9 of 10 checks passed
@tsahee tsahee deleted the snap_sync branch June 4, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amsanghi @tsahee