Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pebble extra options when opening wasm db #2352

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented May 29, 2024

Previously we opened wasm database without pebble extra options specified.
This PR makes use of OpenDatabaseWithExtraOptions to use the same pebble specific options for wasm database as for l2chaindata and arbitrumdata.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 29, 2024
@joshuacolvin0 joshuacolvin0 requested a review from tsahee May 29, 2024 18:34
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge May 29, 2024 22:03
@tsahee tsahee merged commit d5ca4bf into master May 29, 2024
10 checks passed
@tsahee tsahee deleted the wasm-db-use-extra-options branch May 29, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants