Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetL1GasPriceEstimate precompile #776

Merged
merged 2 commits into from Jul 12, 2022
Merged

Conversation

edfelten
Copy link
Contributor

Fix error in GetL1GasPriceEstimate precompile. ArbOS version 1 retains the old behavior for backward compatibility. Newer versions get the updated behavior.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #776 (aa099f8) into master (8d0bd20) will decrease coverage by 4.10%.
The diff coverage is 0.00%.

❗ Current head aa099f8 differs from pull request most recent head 48e8ea1. Consider uploading reports for the commit 48e8ea1 to get more accurate results

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   52.50%   48.39%   -4.11%     
==========================================
  Files         225      213      -12     
  Lines       27086    22955    -4131     
  Branches      494      494              
==========================================
- Hits        14221    11109    -3112     
+ Misses      11332    10323    -1009     
+ Partials     1533     1523      -10     

Copy link
Contributor

@hkalodner hkalodner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkalodner hkalodner enabled auto-merge (rebase) July 12, 2022 15:31
@hkalodner hkalodner merged commit cc87723 into master Jul 12, 2022
@hkalodner hkalodner deleted the fix-get-l1-gas-price-estimate branch July 12, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants