Fix ArbGasInfo get price methods #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 46.67% 46.54% -0.13%
==========================================
Files 215 215
Lines 23856 23907 +51
Branches 502 502
==========================================
- Hits 11134 11128 -6
- Misses 11226 11282 +56
- Partials 1496 1497 +1 |
rachel-bousfield
requested changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some inaccurate results provided by methods of ArbGasInfo that report various prices. In particular, this correctly breaks out the difference between minimum basefee and the congestion component; and it correctly reports the estimated per-tx base charge for L1 data.