Don't panic when connected to a classic feed #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
- Coverage 50.95% 46.60% -4.36%
==========================================
Files 227 215 -12
Lines 28118 23999 -4119
Branches 502 502
==========================================
- Hits 14328 11184 -3144
+ Misses 12297 11316 -981
- Partials 1493 1499 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic messages deserialized as a nil nitro message, which caused a nil deref in the transaction streamer logging. I've also hardened the transaction streamer and broadcast client in a number of similar places.