Add support for validator to just create wallet or contract #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
==========================================
- Coverage 51.78% 47.47% -4.31%
==========================================
Files 228 216 -12
Lines 28447 24346 -4101
Branches 502 502
==========================================
- Hits 14732 11559 -3173
+ Misses 12139 11208 -931
- Partials 1576 1579 +3 |
hkalodner
requested changes
Aug 5, 2022
cmd/nitro/nitro.go
Outdated
Comment on lines
789
to
791
| if !chainFound { | ||
| // If persistent-chain not defined, user not creating custom chain | ||
| return nil, nil, nil, nil, nil, fmt.Errorf("Unknown chain with L1: %d, L2: %d\n", l1ChainId.Uint64(), l2ChainId) |
There was a problem hiding this comment.
We might still want to say something about setting the persistent chain since they could have a full custom config?
Comment on lines
+410
to
419
| daSigner, err = arbnode.GetSignerFromWallet(l1Wallet) | ||
| if err != nil { | ||
| fmt.Printf("%v\n", err.Error()) | ||
| return | ||
| } | ||
|
|
||
| l1TransactionOpts, err = util.GetTransactOptsFromWallet( | ||
| l1Wallet, | ||
| new(big.Int).SetUint64(nodeConfig.L1.ChainID), | ||
| ) |
There was a problem hiding this comment.
At some point we really need to unify these code paths, but I don't think it's worth it for now
hkalodner
reviewed
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.