All CAP features #21
All CAP features #21
Conversation
robin-liao
commented
Apr 4, 2019
•
robin-liao
commented
- Adaptive Card
- BotBuilder actions wrapped into Adaptive Card
- Task Module
- Messaging Extension - create card
- Messaging Extension - message actions
- Messaging Extension - message preview
- Messaging Extension - app-based link
- FileBot sample (user ->bot & bot -> user file sending)
There was a problem hiding this comment.
@robin-liao You have added a bunch of features, can you add one sample for each of them. One for TaskModule, one for file upload etc.
| using System.Threading.Tasks; | ||
| using Microsoft.Bot.Schema.Teams; | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
Would this class even work in most cases? If the invoke responses were sent as null wouldn't BotFramework throw BadRequest?
There was a problem hiding this comment.
I copied the implementation of Task.FromResult<InvokeResponse>(null); from your Wiki example. Of course it won't work for each case since for some cases invoke response requires a specific type. My intention is to have a default implementation so as to prevent from breaking existing classes given adding more invokes in the future. Note that we're having a bunch of invoke handlers and we're adding more for sure. Having one more newly added interface will potential break all existing derived classes as they're directly implementing the set of interface (instead of deriving from base class) and there's no choice to have optional interface implementation by default. To keep a default base class can avoid this design problem. An alternative solution is to throw exceptions for non-implemented methods instead of return null. Thought?
@RamjotSingh I have added a MessageExtension bot in this PR that includes all the CAP features. It aligns with the Node SDK example. But I missed the file part. I can add one more file bot as I also did it in Node SDK. |
@RamjotSingh added a |
