Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity Feed notification Change and fix #641

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Activity Feed notification Change and fix #641

merged 2 commits into from
Dec 30, 2022

Conversation

Pawan-MSFT
Copy link
Contributor

No description provided.

Prithvi-MSFT
Prithvi-MSFT approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@Prithvi-MSFT Prithvi-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine

ChetanSharma-msft
ChetanSharma-msft requested changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comments.

...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/TeamMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/TeamMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/TeamMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/ChatMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
...ph-activity-feed/csharp/ActivityFeedNotification/Helpers/TeamMembersNotificationRecipient.cs Outdated Show resolved Hide resolved
samples/graph-activity-feed/csharp/ActivityFeedNotification/Controllers/HomeController.cs Show resolved Hide resolved
samples/graph-activity-feed/csharp/ActivityFeedNotification/Controllers/HomeController.cs Show resolved Hide resolved
ChetanSharma-msft
ChetanSharma-msft approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine, approving it.

@ChetanSharma-msft
Copy link
Collaborator

ChetanSharma-msft commented Dec 30, 2022 •
edited

Executed build pipeline: https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/3805362929

image

@ChetanSharma-msft ChetanSharma-msft merged commit e51a65d into main Dec 30, 2022
Prithvi-MSFT pushed a commit to Prithvi-MSFT/Microsoft-Teams-Samples-git that referenced this pull request Feb 13, 2023
@Pawan-MSFT @Prithvi-MSFT
Activity Feed notification Change and fix (OfficeDev#641)
358669a 
* Activity Feed notification Change and fix

* Fixed PR feedbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wajeed-msft Wajeed-msft Wajeed-msft approved these changes

@ChetanSharma-msft ChetanSharma-msft ChetanSharma-msft approved these changes

@Prithvi-MSFT Prithvi-MSFT Prithvi-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Pawan-MSFT @ChetanSharma-msft @Wajeed-msft @Prithvi-MSFT @Pawank-MSFT