Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Office ASP.NET SSO sample #417

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Update Office ASP.NET SSO sample #417

merged 8 commits into from
Nov 8, 2022

Conversation

davidchesnut
Copy link
Member

Q A
Bug fix? no
New feature? no
New sample? no
Related issues? ---

What's in this Pull Request?

  • Remove fallback code as it now requires a second app registration which is a bit complex to include in this sample at this time.
  • Upgrade to use ASP.NET Core.

@davidchesnut davidchesnut mentioned this pull request Oct 31, 2022
Closed
AlexJerabek
AlexJerabek reviewed Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the readme for this sample updated? The folder names and the middle-tier warning seem out of date.

@davidchesnut
Copy link
Member Author

@AlexJerabek I updated the readme, so should be good now. Thanks!

AlexJerabek
AlexJerabek approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some link fix suggestions.

Samples/auth/Office-Add-in-ASPNET-SSO/README.md Outdated Show resolved Hide resolved
Samples/auth/Office-Add-in-ASPNET-SSO/README.md Outdated Show resolved Hide resolved
Samples/auth/Office-Add-in-ASPNET-SSO/README.md Outdated Show resolved Hide resolved
@davidchesnut davidchesnut merged commit 5f4458d into main Nov 8, 2022
@davidchesnut davidchesnut deleted the davech-update-aspnet-sso2 branch November 8, 2022 22:05
@jimbarrett33 jimbarrett33 mentioned this pull request Nov 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexJerabek AlexJerabek AlexJerabek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidchesnut @AlexJerabek