Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Outlook SSO sample to ASP.NET Core latest #441

Closed
wants to merge 1 commit into from

Conversation

davidchesnut
Copy link
Member

Q A
Bug fix? no
New feature? no
New sample? no
Related issues? na

What's in this Pull Request?

Update project to ASP.NET Core latest.

@davidchesnut davidchesnut changed the title combined checkin update to ASP.NET Core Update Outlook SSO sample to ASP.NET Core latet Dec 1, 2022
@davidchesnut davidchesnut changed the title Update Outlook SSO sample to ASP.NET Core latet Update Outlook SSO sample to ASP.NET Core latest Dec 1, 2022
1. Copy and save the client secret value. You'll use it in later procedures.
| Placeholder or section | Value |
|---------------------|-------------------------------------|
| <add-in-name> | AttachmentDemo |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The angle brackets are causing this to not render correctly.

image

| Placeholder or section | Value |
|---------------------|-------------------------------------|
| <add-in-name> | AttachmentDemo |
| Microsoft Graph permissions | openid, profile, offline_access, Files.ReadWrite, Mail.Read|

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a listing for the Redirect URI?
image

It's referenced in the article, but never given a value:
image


1. Under **Manage**, select **Expose an API**.
Follow the steps in [Register an Office Add-in that uses single sign-on (SSO) with the Microsoft identity platform](https://learn.microsoft.com/office/dev/add-ins/develop/register-sso-add-in-aad-v2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this part of the conceptual doc:
image
Consider repeating the instruction to record the secret value in the step itself. If people skip the hint box, they'll miss the actual instruction.

1. Replace the `[Enter the Client Id (Application ID obtained from the Azure portal)]` value in both places where it appears with the application ID you generated as part of the app registration process.
1. Replace the `[Copy the client secret added to the app from the Azure portal]` value with the client secret you generated as part of the app registration process.
1. In the **Solution Explorer**, open **AttachmentDemo-ASPNETCore > appsetings.json**.
1. Replace the `Enter_client_ID_here` placeholder value with the application ID you generated as part of the app registration process.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terms "client ID" and "application ID" seem to be used interchangeably in this doc. Is that intentional?

@davidchesnut davidchesnut deleted the davech-outlook-sso-update branch December 10, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants