Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file type support for React #114

Merged
merged 2 commits into from Apr 11, 2024
Merged

Add file type support for React #114

merged 2 commits into from Apr 11, 2024

Conversation

davidchesnut
Copy link
Member

Thank you for your pull request! Please provide the following information.


Change Description:

The template is broken and won't build and run as you will get multiple errors about ttf, woff, and woff2 file types from React usage. This PR updates the webpack.config.js to include these additional file types so they will load correctly.
  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
    No.

  2. Do these changes impact VS Code debugging options (launch.json)?
    No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
    No.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
    No.

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct

Validation/testing performed:

Describe manual testing done. 

@davidchesnut davidchesnut requested a review from a team as a code owner February 20, 2024 23:55
@davidchesnut davidchesnut reopened this Feb 28, 2024
@davidchesnut davidchesnut merged commit a8225af into master Apr 11, 2024
4 checks passed
@davidchesnut davidchesnut deleted the davech-fix-loaders branch April 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants