Merge office addin taskpane #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add CODEOWNERS file
- Also make small change to launch.json to fix issue that was causing 'Debug Tests' config to fail after updating mocha version.
-Verified tests pass locally
The office-addin-debugging package is being updated to have sideload integrated rather than require using office-toolbox. This removes the sideload and unload package.json scripts which are no longer needed. They could be replaced using a command like: "npx office-addin-dev-settings sideload manifest.xml -a excel" however this would require a dev dependency on office-addin-dev-settings. I think it would be simpler to just use the "start" and "stop" scripts instead. These scripts were required previously so that "office-addin-debugging start" would know how to sideload, but now that this functionality is part of the office-addin-dev-settings package, it can import and call it directly.
- This will ensure we pick up important office-addin-scripts changes as well
akrantz
approved these changes
Aug 17, 2019
|
One of the CI build agents was cancelled. I just did Retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.