-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit milliseconds to three digits #741
Conversation
@tomjebo can you review this as it's more up your alley. Is the form consistent with the spec? Let's add the section from the spec for reference |
@stoiveyp can you update the changelog to include this change? You may need to merge the latest changes from master if you don't have a 2.11.1 spot for the changes. |
Also, would it make sense to provide a parse function? We want to get a revision version out which we don't expose new APIs, but we could expose it on the next minor version |
Could we use |
@twsouthwick sorry for the delay - day job has worn me out this week! |
Update from master
Move parsing to static methods
@twsouthwick moved the string conversion to static methods in CellValue and moved the formats to constants Can't find anything in the OpenXml spec specifically about date time cell values.
So without comment within the OpenXml spec or Excel documentation - a processor based on the Xml Schema spec would only have to support the three digits we're now outputting. |
LGTM! I've opened #752 to add a parsing method so people don't need to know the value to get a strongly typed value. That will have to go into a minor version (which may end up being the next version... there's a few APIs we'll want to expose soon). |
Fixes #724 and adds test to ensure that's all that changes
No standard format limits to three digits for milliseconds, but the format is the same as
"o"
used before in all other regards