Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Callback hierarchy is an incomplete mess #10

Open
Noblebrown opened this issue Sep 1, 2014 · 0 comments
Open

The Callback hierarchy is an incomplete mess #10

Noblebrown opened this issue Sep 1, 2014 · 0 comments
Labels

Comments

@Noblebrown
Copy link

The hierarchy starting with the interface Callback is obviously incomplete and non-functional. AbstractAsyncCallback works with a mutable static boolean to determine if it should run the child method of processMe(), and when it does, it sets the boolean and sleeps for one second.

Not only is the static variable usage in a class designed for multithreading horrific, but the whole thing doesn't even do much of anything. I'm guessing that this was test code that was never completed and left in place. This hierarchy should be revised. I'd recommend flattening it and allowing for easy extension to add desired behavior.

@vboctor vboctor added the bug label Sep 2, 2014
@vboctor vboctor changed the title Bug: The Callback hierarchy is an incomplete mess The Callback hierarchy is an incomplete mess Sep 2, 2014
jamieb22 pushed a commit to stimulussoft/ews-java-api that referenced this issue Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants