Merge pull request #74 from waldekmastykarz/issue-73

Fixed bug in the validateHighResolutionIconUrl function #73
OfficeDev · Oct 19, 2015 · 0cc868a · 0cc868a
2 parents 9d888ed + a51e6c4
commit 0cc868a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/generators/content/templates/common/gulpfile.js b/generators/content/templates/common/gulpfile.js
@@ -53,8 +53,10 @@ gulp.task('validate-xml', function () {
 
 function validateHighResolutionIconUrl(xml, result) {
   if (xml && result) {
-    if (xml.indexOf('<HighResolutionIconUrl ') > -1 &&
-      xml.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
+    var xmlString = xml.toString();    
+
+    if (xmlString.indexOf('<HighResolutionIconUrl ') > -1 &&
+      xmlString.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
         if (result.errors === null) {
           result.errors = [];
         }

diff --git a/generators/mail/templates/common/gulpfile.js b/generators/mail/templates/common/gulpfile.js
@@ -53,8 +53,10 @@ gulp.task('validate-xml', function () {
 
 function validateHighResolutionIconUrl(xml, result) {
   if (xml && result) {
-    if (xml.indexOf('<HighResolutionIconUrl ') > -1 &&
-      xml.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
+    var xmlString = xml.toString();    
+
+    if (xmlString.indexOf('<HighResolutionIconUrl ') > -1 &&
+      xmlString.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
         if (result.errors === null) {
           result.errors = [];
         }

diff --git a/generators/taskpane/templates/common/gulpfile.js b/generators/taskpane/templates/common/gulpfile.js
@@ -53,8 +53,10 @@ gulp.task('validate-xml', function () {
 
 function validateHighResolutionIconUrl(xml, result) {
   if (xml && result) {
-    if (xml.indexOf('<HighResolutionIconUrl ') > -1 &&
-      xml.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
+    var xmlString = xml.toString();    
+
+    if (xmlString.indexOf('<HighResolutionIconUrl ') > -1 &&
+      xmlString.indexOf('<HighResolutionIconUrl DefaultValue="https://') < 0) {
         if (result.errors === null) {
           result.errors = [];
         }