Skip to content

Commit

Permalink
Merge pull request #187 from shiftylogic/master
Browse files Browse the repository at this point in the history
Yeoman prior to v0.23 expected prompt function to pass callback, 0.23 changed to promise.
  • Loading branch information
beth-panx committed Oct 12, 2016
2 parents 69459dd + f68ca2f commit ea5f6d0
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 19 deletions.
6 changes: 3 additions & 3 deletions generators/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, this.options);
this.genConfig = extend(this.genConfig, responses);
done();
Expand All @@ -150,7 +150,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down Expand Up @@ -207,7 +207,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down
8 changes: 4 additions & 4 deletions generators/commands/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ module.exports = generators.Base.extend({
];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, this.options);
this.genConfig = extend(this.genConfig, responses);
done();
Expand Down Expand Up @@ -238,7 +238,7 @@ module.exports = generators.Base.extend({
];

var done = this.async();
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down Expand Up @@ -311,7 +311,7 @@ module.exports = generators.Base.extend({
];

var done = this.async();
this.prompt(prompts, function(response) {
this.prompt(prompts).then(function(response) {
this.genConfig = extend(this.genConfig, response);
done();
}.bind(this));
Expand Down Expand Up @@ -358,7 +358,7 @@ module.exports = generators.Base.extend({
}

var done = this.async();
this.prompt(prompts, function(response) {
this.prompt(prompts).then(function(response) {
this.genConfig = extend(this.genConfig, response);
done();
}.bind(this));
Expand Down
6 changes: 3 additions & 3 deletions generators/content/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, this.options);
this.genConfig = extend(this.genConfig, responses);
done();
Expand All @@ -179,7 +179,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down Expand Up @@ -212,7 +212,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down
6 changes: 3 additions & 3 deletions generators/mail/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, this.options);
this.genConfig = extend(this.genConfig, responses);
done();
Expand All @@ -176,7 +176,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down Expand Up @@ -209,7 +209,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down
10 changes: 5 additions & 5 deletions generators/taskpane/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = generators.Base.extend({
desc: 'Office client product that can host the add-in',
required: false
});

this.option('appId', {
type: String,
desc: 'Application ID as registered in Azure AD',
Expand Down Expand Up @@ -152,14 +152,14 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, this.options);
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));

}, // askFor()

askForAdalConfig: function(){
// if it's not an ADAL app, don't ask the questions
if (this.genConfig.tech !== 'ng-adal') {
Expand All @@ -177,7 +177,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down Expand Up @@ -210,7 +210,7 @@ module.exports = generators.Base.extend({
}];

// trigger prompts
this.prompt(prompts, function(responses){
this.prompt(prompts).then(function(responses){
this.genConfig = extend(this.genConfig, responses);
done();
}.bind(this));
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"deep-extend": "^0.4.1",
"lodash": "^4.16.4",
"uuid": "^2.0.3",
"yeoman-generator": "^0.22.1",
"yeoman-generator": "^0.24.1",
"yosay": "^1.2.1",
"xml2js": "^0.4.17"
},
Expand Down

0 comments on commit ea5f6d0

Please sign in to comment.