Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra commands from default generator flow #152

Merged
merged 2 commits into from Mar 8, 2016

Conversation

pcostesi
Copy link
Contributor

@pcostesi pcostesi commented Mar 2, 2016

Rely on subgenerators/commands to get that info. We're keeping the
options in app.js so they transfer to subgenerators.

Fixes #10.

Tests:

  • created a new folder and ran "yo office" inside. Selected the default options, save for "task pane". Result: does not hang.
  • created a new folder and ran "yo office:taskpane" inside. Ran with default options. Result: does not hang.
  • created a new folder and ran "yo office:mail" inside. Ran with default options. Result: hangs.
  • created a new folder and ran "yo office" inside. Ran with default options, save for "mail". Result: hangs.
  • created a new folder and ran "to office:content". Ran with default options. Result: does not hang.

Rely on subgenerators/commands to get that info. We're keeping the
options in `app.js` so they transfer to subgenerators.

Fixes OfficeDev#10.
@msftclas
Copy link

msftclas commented Mar 2, 2016

Hi @pcostesi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Paul Costesich). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

These options were duplicated, and I forgot to commit them during the
test phase.
@jthake jthake modified the milestone: 0.6.5 Mar 8, 2016
@jthake jthake merged commit 4774019 into OfficeDev:dev Mar 8, 2016
@jthake
Copy link
Contributor

jthake commented Mar 8, 2016

Merged into Dev and under release 0.6.5 plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants