Add SupportUrl element to Mail addin manifest file #179
Conversation
This fix provides a default value similar to Description. Maybe in the future, yo can ask for the support url and insert it as a value.
|
Hi @vboctor, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -7,6 +7,7 @@ | |||
| <DefaultLocale>en-US</DefaultLocale> | |||
| <DisplayName DefaultValue="<%= projectDisplayName %>" /> | |||
| <Description DefaultValue="[Outlook Add-in description]"/> | |||
| <SupportUrl DefaultValue="http://contoso.com/support" /> | |||
There was a problem hiding this comment.
SupportUrl element is only required if the add-in is built to be submitted to the Office Store. Some customers build their add-ins to be used internally only and this won't be necessary. If you could add a comment to it and provide an example such as <!--<SupportUrl DefaultValue="[Outlook Add-in support url]">-->, I'd be happy to merge it into the source code.
There was a problem hiding this comment.
The reason I added this entry is that the manifest validator was complaining on this field missing. I can see other fields like Description where we have a "[Outlook Add-in description]" default value and Provider with "[Provider Name]". So we can either have a place holder, e.g. "[Support URL]" or not fail the manifest validation when this field is not supplied or supplied but empty. Thoughts?
P.S. Thanks for reviewing the PR.
There was a problem hiding this comment.
No problem :) Thanks for using this tool.
I have been playing with Yo Office and found some issues with the validator itself. I am currently working on some of the changes so hopefully soon it won't complain about it. :p As of right now, the validation process is failing for me on some specific scenarios even after adding SupportUrl element to it. So at this point, I think either way could serve as a temporary workaround: a. add comment b. add SupportUrl.
There was a problem hiding this comment.
It would be great to fix the validator since this field is not required. Maybe it should have a --public to validate for publishing a public add-on, and hence fields like support url become required.
Feel free to close this PR or let me know what kind of change you would be willing to merge.
There was a problem hiding this comment.
Great point! I am putting this down as a task for the sprint. Will close this pr then :)
This fix provides a default value similar to Description. Maybe in the future, yo can ask for the support url and insert it as a value.
Fixes #175