Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest element update #184

Merged
merged 3 commits into from Oct 6, 2016
Merged

Manifest element update #184

merged 3 commits into from Oct 6, 2016

Conversation

beth-panx
Copy link
Member

Added IconUrl element to have a default value. Added comment for optional SupportUrl element. Updated tests to cover these changes.

@msftclas
Copy link

msftclas commented Oct 5, 2016

Hi @beth-panx, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Beth Pan). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@coveralls
Copy link

coveralls commented Oct 5, 2016

Coverage Status

Coverage remained the same at 98.287% when pulling 29d083e on manifest-element-update into 3d2383d on master.

@beth-panx
Copy link
Member Author

@jasonjoh would you like to review the changes I made that added IconUrl and optional SupportUrl elements to manifest files? This will close issue #175 and #181

Copy link
Contributor

@jasonjoh jasonjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants