Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sso option back #728

Merged
merged 2 commits into from Sep 2, 2022
Merged

Add sso option back #728

merged 2 commits into from Sep 2, 2022

Conversation

millerds
Copy link
Contributor

Thank you for your pull request. Please provide the following information.


  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • Yes
    • No

    If Yes, briefly describe what is impacted.

  2. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • Yes
    • No

    If Yes, briefly describe what is impacted.

  3. Validation/testing performed:

    Verified sso project option is available and is able to create projects of that type

  4. Platforms tested:

    • Windows
    • Mac

@millerds millerds requested a review from a team as a code owner August 29, 2022 22:39
@davidchesnut
Copy link
Member

Is there a way to warn developers not to use this for production purposes? All of the templates support deployment to Azure (or similar) except for this one. It seems implied that the SSO template would also support production and deployment to Azure and we should warn or say for "localhost use only" or something.

igor-ribeiiro
igor-ribeiiro previously approved these changes Aug 30, 2022
@millerds millerds merged commit b56d4b0 into OfficeDev:master Sep 2, 2022
@millerds millerds deleted the fix-sso branch September 2, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants