Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added url search parameters for insecure e2e testing #2336

Merged
merged 9 commits into from
May 21, 2024
Merged

Added url search parameters for insecure e2e testing #2336

merged 9 commits into from
May 21, 2024

Conversation

shrshindeMSFT
Copy link
Contributor

@shrshindeMSFT shrshindeMSFT commented May 21, 2024 •
edited
Loading

For more information about how to contribute to this repo, visit this page.

Description

Added search URL parameter origins to send origins to app.initialize().

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added a URL search parameter origins.

Validation

Validation performed:

N/A

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

No

End-to-end tests added:

No

@shrshindeMSFT shrshindeMSFT requested a review from a team as a code owner May 21, 2024 16:40
@shrshindeMSFT shrshindeMSFT enabled auto-merge (squash) May 21, 2024 17:49
@erinha
Copy link
Contributor

erinha commented May 21, 2024

Can you please update the PR description too (after the param rename)?

erinha
erinha approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@erinha erinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shrshindeMSFT shrshindeMSFT merged commit 2bb7aa8 into main May 21, 2024
21 checks passed
@shrshindeMSFT shrshindeMSFT deleted the shrshinde/E2ETestsForInvalidOrigins branch May 21, 2024 20:46
shrshindeMSFT added a commit that referenced this pull request May 22, 2024
@shrshindeMSFT
Added url search parameters for insecure e2e testing (#2336)
739ddf3 
* Add url search parameters for insecure e2e testing

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakhveerk lakhveerk lakhveerk left review comments

@erinha erinha erinha approved these changes

@jekloudaMSFT jekloudaMSFT jekloudaMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shrshindeMSFT @erinha @lakhveerk @jekloudaMSFT