Skip to content
This repository has been archived by the owner on Jun 12, 2019. It is now read-only.

Switch to using Angular zone #929

Closed
hongbo-miao opened this issue Jun 13, 2017 · 1 comment
Closed

Switch to using Angular zone #929

hongbo-miao opened this issue Jun 13, 2017 · 1 comment
Assignees

Comments

@hongbo-miao
Copy link
Contributor

hongbo-miao commented Jun 13, 2017

Article:
https://github.com/OfficeDev/office-js-docs/blob/master/docs/develop/add-ins-with-angular2.md

Issue:
The notifications to update the DOM occasionally do not fire is because the codes run out of Angular zone. A good practice is putting that part of code in the zone, instead of forcing the update.

this.zone.run(() => {
  // ...
});

I will add a PR soon when I get time.

@hongbo-miao hongbo-miao self-assigned this Jun 13, 2017
@hongbo-miao
Copy link
Contributor Author

#997

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant