Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Fixes issue 102 #106

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes issue 102 #106

wants to merge 4 commits into from

Conversation

sremiger1
Copy link

In IE or the outlook desktop the token can be deleted if the token is expired. The get method to get the token actual token without the expire check is over written, therefore the calls to the get method that checks to the token to be expired is being called in the delete method and the infinite loop is created.

Fixed Issue 102
Update the README.md to reflect the change to the get call
@msftclas
Copy link

msftclas commented Aug 27, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@sumurthy sumurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a rename? I don't see the relation between issue explained and the change made here.

@sremiger1
Copy link
Author

The old get within the token manager is being called and only returns a token if it is valid. If the token is expired this method attempts to delete that same token, by calling the delete method. The delete method in-turn called the old get method. So the code ends up going out of stack. By renaming this method to getValidToken, this method will return a valid token only. Using the same code now, when the token is expired and the delete is called the delete will call the super get that does not validate the token, it just returns a token if found.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants