-
Notifications
You must be signed in to change notification settings - Fork 467
Missing component javascripts. #67
Comments
Great catch, thanks. I think this is actually an issue with the template used for component samples, which expects a JS file for a component even if one doesn't exist, hence the 404s. We will clean that up. |
Awesome, go get 'em Peter. |
Thanks again for flagging this. I'll reactivate this issue for now until we've resolved it--we don't have an ETA yet but I want to be sure it's clear we're aware of it :) |
I am trying to make use of the dialog but the samples don't show how to open/close a dialog is there some missing js files as the sample references Jquery.Dialog.js However, these do not exist? |
In the fabric site the Spinner page doesn't show the js tab alongside the demo html. It should have as it is in the markup of the page, just not showing up. |
…r opening and closing. Adjust component sample page so dialogs are modal. Add additional variant to demonstration different configurations for light closing and blocking dialogs.
@digglek - #274 should help with the JS for the Dialog. We've also included an example of a blocking dialog for extra completeness. @weshackett - we'll get the examples up on the site asap for both the Spinner and the Dialog. |
Fix issue #67 - Update Dialog component samples
Issue #110 covers needing JS to demonstrate opening and closing a Dialog. |
It seems like each of your Samples (in dist/samples/components/) are all missing their associated .js files. For example, the ChoiceField component index.html (see here: https://github.com/OfficeDev/Office-UI-Fabric/blob/master/dist/samples/Components/ChoiceField/index.html#L15) calls a file named ChoiceField.js which doesn't exist. Same thing for all the other components I've looked at.
The text was updated successfully, but these errors were encountered: