Converted Components and Samples over to SASS #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated component helper to include name of Pre-processor - Removed outdated Component Example html
…into miljo/less-sass-components
- Converted all Icons to Mixins so they can be used throughout SASS. - Converted all components over to SASS - FIxed All errors in Sass Files. - Created a couple helper tasks for converting over mixins
…eDev/Office-UI-Fabric into miljo/less-sass-components
…into miljo/less-sass-components # Conflicts: [RESOLVED] # gulp/ComponentSamples.js # gulp/FabricBuild.js # gulp/FabricComponents.js # gulp/modules/ComponentHelper.js # gulp/modules/Plugins.js # src/less/_Fabric.Animations.less
- Working on fixing an issue where the LESS compiler should not be running but it is anyway.
- Removing build config from each file
- Now working for Samples - Removed Sass linting unti gup-sass-lint fixes a big bug. - Setup a config for Sass-lint, keeping until we get Sass linting working. - Fixed two icons that were not working.
- Had to fix up the circle icon on button.
|
I'm having trouble getting the build system to use Sass rather than LESS. I've run |
| @@ -0,0 +1,108 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. Licensed under the MIT license. See LICENSE in the project root for license information. | |||
There was a problem hiding this comment.
Seems like this styling is from a previous version of SearchBox.
|
I did a comparison of the dist/ output from 'master' and this branch. There are some differences (mostly in source order and things like changing |
Closed
gokunymbus
added a commit
that referenced
this pull request
Jan 26, 2016
Converted Components and Samples over to SASS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.