Remove LESS #303
Remove LESS #303
Conversation
|
Have you checked out the copy/build steps in FabricBuild.js? Since you've removed the LESS dependencies but not the tasks that use them, those tasks will fail (hence the failing build). |
|
Working on fixing the build now... |
Conflicts: src/components/Persona/Persona.less
| // Style Linting | ||
| // ---------------------------------------------------------------------------- | ||
|
|
||
| gulp.task('ComponentSamples-styleHinting', function() { |
There was a problem hiding this comment.
Interesting--is there no linting for SASS built in that we can switch to? We definitely want that included, very soon if not right now in this PR. I realize that's scope creep but it's an important aspect of development we shouldn't lose.
|
Overall, looks really good. Biggest issue I can see is a lack of SASS linting/error reporting now that LESS is no longer part of the build at all. Also, this probably doesn't need to be addressed in this PR, we should consider whether we need some of the leftover config bits from supporting 2 preprocessors, e.g. running a task for setting SassMode explicitly (it's the only mode now) and the sassExtension prop in Config.js. |
|
Also, please remove component-manifest-template.less--that's no longer needed either. |
…into miwhea/remove-less # Conflicts: # src/components/Spinner/Spinner.less [Resolved] # src/less/Fabric.RTL.less [Resolved] # src/less/Fabric.less [Resolved]
This should get us all the way to completing #56. @battletoilet, please have a look at the build process to see if I've missed anything.