This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Change List and ListItem markup to use <li> #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2016 17:46
…ock display to ms-ListItem to override default list display.
mikewheaton
changed the title
|
Fantastic--looks great! Approved. |
|
I don't see any regressions. Approved! |
mikewheaton
pushed a commit
that referenced
this pull request
Feb 13, 2016
Change List and ListItem markup to use <li>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #304. I've updated the template for List to use
uland ListItem to useli. While a ListItem could be used outside of a List as a simplediv, for consistency I've wrapped each ListItem in a List.