This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Ensures the hero button icon is centered within the circle #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good in all browsers except in Edge for me. |
| @@ -131,6 +131,7 @@ | |||
| font-size: $ms-font-size-s; | |||
| position: relative; | |||
| top: -8px; | |||
| text-align: center; | |||
There was a problem hiding this comment.
Align to the other CSS properties in this class.
|
The icon centers horizontally in Edge, but it sits about a pixel too low in the circle. This is more an issue with the icon font not having vertically centered icons than a bug with this component. Even if we tweaked it for the plus icon, this component should support any icon and we can't get them all aligned. |
|
Looks good to me. Approved. |
|
Agreed--looks good. |
mikewheaton
pushed a commit
that referenced
this pull request
Feb 12, 2016
Ensures the hero button icon is centered within the circle. Fixes #346
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #346