This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Theme color updates and message colors #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 21, 2016 10:13
…s. Removed some hover classes that weren't documented to bring functionality in line with other accent colors.
|
Message colors have been added to the documentation site. |
|
Updated the changed theme colors for the documentation site. |
| $ms-color-error: $ms-color-redDark; | ||
| $ms-color-errorBackground: #fde7e9; | ||
| $ms-color-info: $ms-color-green; | ||
| $ms-color-infoBackground: $ms-color-neutralLighter; | ||
| $ms-color-success: $ms-color-green; | ||
| $ms-color-successBackground: #dff6dd; |
There was a problem hiding this comment.
Should this be in a variable instead?
There was a problem hiding this comment.
What should be in a variable?
There was a problem hiding this comment.
The successBackground & errorBackground (not shown in the above code snippit)
There was a problem hiding this comment.
Oh I see. Those actually are variables and are with the others in _Fabric.Color.Variables.scss. It's just that some of the other message color variables are mapped to existing colors, and those two values are specific to messages.
|
looks good |
mikewheaton
pushed a commit
that referenced
this pull request
Feb 24, 2016
Theme color updates and message colors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here look more extensive than they are – I mostly just changed the order of the message colors (info, success, alert, warning) and made sure that "orangeLighter" is moved in with the other accent colors.
The message colors have been an undocumented feature of Fabric. This pull request is just to tidy up the mixins and classes to prepare for documenting them. There are no new classes or changes to the message colors.
For the theme colors,
secondary,tertiary, andlighthave all changed slightly.