Inline version number instead of file based #890
Conversation
|
Hi @micahgodbolt, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
There was a problem hiding this comment.
Approved
Thanks so much for doing this @micahgodbolt! Before completing, could you also remove src/documentation/templates/scoped-fabric-template.scss? This work removes the need for that file. Thanks!
| @@ -4,8 +4,12 @@ | |||
| // Office UI Fabric | |||
| // Core styles scoped to the current major version of Fabric | |||
|
|
|||
| // Fabric version gets set on compile | |||
| $ms-fabric-version: $FabricVersion; | |||
| // | |||
There was a problem hiding this comment.
We aren't doing this elsewhere--please remove.
| @@ -4,8 +4,12 @@ | |||
| // Office UI Fabric | |||
| // Core styles scoped to the current major version of Fabric | |||
|
|
|||
| // Fabric version gets set on compile | |||
There was a problem hiding this comment.
Could you expand this to say something along the lines of "$FabricVersion becomes a SASS list like [1,2,3] on build"
|
Approved 👍 |
No description provided.