Toggle js init value #170
Toggle js init value #170
Conversation
…utton-buttonBase to remove the ugly black border on the menue buttons
|
Thanks for the PR @seriewe. What's the purpose of these changes? What are you trying to solve? |
|
Hi, if my toggle is checked on server side and the view is rendered, the checkbox was not selected by fabric ui. So I check the "checked" Attribute and set is-selected. Sorry for the confusing stuff with the border inside the pull request. The important stuff is inside the Toggle.ts ctor. |
src/components/Toggle/Toggle.ts
Outdated
| @@ -35,7 +40,6 @@ namespace fabric { | |||
| } | |||
|
|
|||
| private _toggleHandler(): void { | |||
| this._toggleField.classList.toggle("is-selected"); | |||
There was a problem hiding this comment.
_toggleHandler() now does nothing yet the method is still used as a callback to a few events. Was removing this method's body intentional?
There was a problem hiding this comment.
Hi, no this was a mistake. The _toggleHandler() should still stay the same. Should I create a new PullRequest?
…ice-ui-fabric-js into toggle-js-init-value
…ice-ui-fabric-js into toggle-js-init-value
|
Microsoft no longer supports this content and will not be responding to bugs or issues. We recommend that you use the newer version, Office UI Fabric, with React as your front-end framework. We are closing this issue; if you still need assistance with Fabric.js, visit Stack Overflow/office-ui-fabric. |
Init toggle value as selected if is checked attribute set