PeoplePicker - Korean Characters issue in IE11 #10432

amyngu · 2019-09-11T22:52:54Z

Pull request checklist

Addresses an existing issue: Fixes PeoplePicker - Korean Characters issue in IE11. #8082
Include a change request file using $ yarn change

Description of changes

Remove work around for React issue for Korean IME (fixed in React 16.5)
Listen to onCompositionUpdate instead of onInput when composing in IME

Focus areas to test

Autofill & People Pickers

Microsoft Reviewers: Open in CodeFlow

amyngu · 2019-09-11T22:59:33Z

@yumikohey @Adjective-Object not sure why I can't add reviewers, please take a look

size-auditor · 2019-09-11T23:08:03Z

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	ExtendedPicker	82.92 kB	83.061 kB	141 bytes
office-ui-fabric-react	Autofill	24.622 kB	24.763 kB	141 bytes
office-ui-fabric-react	ComboBox	224.11 kB	224.251 kB	141 bytes
office-ui-fabric-react	Pickers	261.481 kB	261.622 kB	141 bytes

Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B

Baseline commit: 3682e4b101a264192d36d2a7ceb59ad877661e6f (build)

KevinTCoughlin

@joschect please review

packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx

joschect · 2019-09-12T18:20:12Z

@KevinTCoughlin yep, I'm taking a look at it now. It's taken me a sec to get my windows machine setup to test.

joschect · 2019-09-12T21:40:30Z

@amyngu awesome job! Thanks for doing that.

KevinTCoughlin · 2019-09-12T23:25:28Z

@amyngu it looks like snapshots need to be updated for CI to pass.

msft-github-bot · 2019-09-12T23:25:28Z

Hello @KevinTCoughlin!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msft-github-bot`) and give me an instruction to get started! Learn more here.

…ll.tsx Co-Authored-By: Kevin Coughlin <706967+KevinTCoughlin@users.noreply.github.com>

KevinTCoughlin · 2019-09-17T21:50:47Z

Looks like another case of @uifabric/experiments not updating when yarn update-snapshots is run from root.

But no snapshot files churn when running the command local to the experiments directory...

~\Work\office-ui-fabric-react\packages\experiments [keco/autoFillKoreanIE11]> yarn update-snapshots                     yarn run v1.17.3
$ just-scripts jest -u
[2:56:05 PM] ■ started 'jest'
[2:56:05 PM] ■ Running Jest
[2:56:05 PM] ■ C:\Program Files\nodejs\node.exe "C:\Users\keco.REDMOND\Work\office-ui-fabric-react\node_modules\jest\bin\jest.js" --config "C:\Users\keco.REDMOND\Work\office-ui-fabric-react\packages\experiments\jest.config.js" --passWithNoTests --colors --forceExit --updateSnapshot
 PASS  src/components/Slider/Slider.test.tsx (12.599s)
 PASS  src/components/Sidebar/Sidebar.test.tsx (14.988s)
 PASS  src/components/PersonaCoin/PersonaCoin.test.tsx (15.172s)
 PASS  src/components/Button/Button.test.tsx (15.322s)
 PASS  src/components/Toggle/Toggle.state.test.tsx (15.66s)
 PASS  src/components/Button/ButtonVariants/ButtonVariants.test.tsx (15.986s)
 PASS  src/components/Button/SplitButton/SplitButton.test.tsx (16.307s)
 PASS  src/components/Button/MenuButton/MenuButton.test.tsx
 PASS  src/components/Chiclet/Chiclet.test.tsx
 PASS  src/components/Toggle/Toggle.view.test.tsx
 PASS  src/components/Persona/Vertical/VerticalPersona.test.tsx
 PASS  src/components/SelectedItemsList/SelectedItemsList.test.tsx
 PASS  src/components/Pagination/Pagination.test.tsx
Force exiting Jest

Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
[2:56:28 PM] ■ finished 'jest' in 23.59s
Done in 24.93s.

KevinTCoughlin · 2019-09-17T22:07:37Z

Figured out what's required to resolve CI.

@amyngu you'll need to do a full build via yarn build at repo root. Then run yarn update-snapshots in packages/experiments since the file modified is used in both office-ui-fabric-react and @uifabric/experiments.

…-ui-fabric-react into autoFillKoreanIE11

msft-github-bot · 2019-09-18T00:01:31Z

Component Perf Analysis

No significant results to display.

All results

Scenario	Master Ticks	PR Ticks
BaseButton	790	782
BaseButton (experiments)	1047	1016
DefaultButton	1133	1048
DefaultButton (experiments)	2011	1968
DetailsRow	3355	3348
DetailsRow (fast icons)	3475	3406
DetailsRow without styles	3142	3169
DocumentCardTitle with truncation	31963	33317
MenuButton	1411	1416
MenuButton (experiments)	3569	3584
PrimaryButton	1197	1204
PrimaryButton (experiments)	2078	2117
SplitButton	2891	2949
SplitButton (experiments)	7325	7073
Stack	524	537
Stack with Intrinsic children	1233	1215
Stack with Text children	4348	4426
Text	387	382
Toggle	884	877
Toggle (experiments)	2265	2364
button	64	68

msft-github-bot · 2019-09-18T12:33:07Z

🎉@uifabric/experiments@v7.17.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-github-bot · 2019-09-18T12:33:27Z

🎉office-ui-fabric-react@v7.35.0 has been released which incorporates this pull request.:tada:

Handy links:

amyngu added 2 commits September 11, 2019 15:46

listen on composition events only in IME

6887a0c

Change files

3761db0

amyngu requested a review from joschect as a code owner September 11, 2019 22:52

msft-github-bot assigned KevinTCoughlin Sep 11, 2019

KevinTCoughlin reviewed Sep 12, 2019

View reviewed changes

packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx Outdated Show resolved Hide resolved

joschect approved these changes Sep 12, 2019

View reviewed changes

KevinTCoughlin added the AutoMerge label Sep 12, 2019

ecraig12345 added the Component: PeoplePicker label Sep 13, 2019

Update packages/office-ui-fabric-react/src/components/Autofill/Autofi…

e91c2cb

…ll.tsx Co-Authored-By: Kevin Coughlin <706967+KevinTCoughlin@users.noreply.github.com>

msft-github-bot removed the AutoMerge label Sep 17, 2019

KevinTCoughlin added the Needs: Author Feedback label Sep 17, 2019

amyngu added 3 commits September 17, 2019 15:46

update experiment snapshots

36b4998

Merge branch 'master' into autoFillKoreanIE11

160dd8f

Merge branch 'autoFillKoreanIE11' of https://github.com/amyngu/office…

55e2fb7

…-ui-fabric-react into autoFillKoreanIE11

msft-github-bot removed the Needs: Author Feedback label Sep 17, 2019

Change files

ff5d769

KevinTCoughlin added the AutoMerge label Sep 18, 2019

msft-github-bot merged commit dc5d00e into microsoft:master Sep 18, 2019

msft-github-bot mentioned this pull request Sep 18, 2019

PeoplePicker - Korean Characters issue in IE11. #8082

Closed

amyngu mentioned this pull request Sep 19, 2019

Autofill: Fix IME for non IE11 browsers #10527

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PeoplePicker - Korean Characters issue in IE11 #10432

PeoplePicker - Korean Characters issue in IE11 #10432

amyngu commented Sep 11, 2019 •

edited by ecraig12345

Loading

amyngu commented Sep 11, 2019 •

edited

Loading

size-auditor bot commented Sep 11, 2019 •

edited

Loading

KevinTCoughlin left a comment

joschect commented Sep 12, 2019

joschect commented Sep 12, 2019

KevinTCoughlin commented Sep 12, 2019

msft-github-bot commented Sep 12, 2019

KevinTCoughlin commented Sep 17, 2019 •

edited

Loading

KevinTCoughlin commented Sep 17, 2019

msft-github-bot commented Sep 18, 2019

msft-github-bot commented Sep 18, 2019

msft-github-bot commented Sep 18, 2019

PeoplePicker - Korean Characters issue in IE11 #10432

PeoplePicker - Korean Characters issue in IE11 #10432

Conversation

amyngu commented Sep 11, 2019 • edited by ecraig12345 Loading

Pull request checklist

Description of changes

Focus areas to test

Microsoft Reviewers: Open in CodeFlow

amyngu commented Sep 11, 2019 • edited Loading

size-auditor bot commented Sep 11, 2019 • edited Loading

Asset size changes

KevinTCoughlin left a comment

Choose a reason for hiding this comment

joschect commented Sep 12, 2019

joschect commented Sep 12, 2019

KevinTCoughlin commented Sep 12, 2019

msft-github-bot commented Sep 12, 2019

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

KevinTCoughlin commented Sep 17, 2019 • edited Loading

KevinTCoughlin commented Sep 17, 2019

msft-github-bot commented Sep 18, 2019

Component Perf Analysis

msft-github-bot commented Sep 18, 2019

msft-github-bot commented Sep 18, 2019

amyngu commented Sep 11, 2019 •

edited by ecraig12345

Loading

amyngu commented Sep 11, 2019 •

edited

Loading

size-auditor bot commented Sep 11, 2019 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msft-github-bot`) and give me an instruction to get started! Learn more here.

KevinTCoughlin commented Sep 17, 2019 •

edited

Loading