Move command bar out of experiments and into 6.0 #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the file diffs. It's similar enough that git tries to show what changed, but its so completely different that the diffs are almost meaningless |
MLoughry
requested changes
Oct 19, 2017
| contextualMenuProps?: IContextualMenuProps; | ||
| contextualMenuTarget?: HTMLElement; | ||
| renderedFarItems?: IContextualMenuItem[]; | ||
| export interface ICommandBarData { |
There was a problem hiding this comment.
Why not put this in the props file? As it is, you have a circular dependency between this file and the props file.
| data={ commandBardata } | ||
| onReduceData={ onReduceData } | ||
| onGrowData={ onGrowData } | ||
| // tslint:disable-next-line:jsx-no-lambda |
There was a problem hiding this comment.
Rather than disable TSLint, why not refactor this out to a function or a functional component?
micahgodbolt
changed the title
|
It looks like there are actual visual regressions here; I don't think you intended to change paddings? |
|
Padding is the same, image is just zoomed since it's shorter. no search bar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been sitting in experiments far too long. Initial integration into outlook seemed quite good. I'd like to get this moving now that the dust is starting to settle with 5.0.