feat(sdk): notification sdk enhancement for .NET #8486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/dotnet-sdk/src/TeamsFx/Conversation/NotificationBot.cs
Dismissed
Show dismissed
Hide dismissed
packages/dotnet-sdk/src/TeamsFx/Conversation/NotificationMiddleware.cs
Dismissed
Show dismissed
Hide dismissed
Comment on lines
+212
to
+218
| foreach (var member in pagedMembers.Data) | ||
| { | ||
| if (await predicate(member).ConfigureAwait(false)) | ||
| { | ||
| return member; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
packages/dotnet-sdk/src/TeamsFx/Conversation/NotificationMiddleware.cs
Dismissed
Show dismissed
Hide dismissed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #8486 +/- ##
==========================================
+ Coverage 78.65% 78.69% +0.03%
==========================================
Files 606 606
Lines 41845 41884 +39
Branches 8327 8338 +11
==========================================
+ Hits 32913 32960 +47
+ Misses 5595 5579 -16
- Partials 3337 3345 +8 |
swatDong
reviewed
Apr 23, 2023
swatDong
previously approved these changes
Apr 23, 2023
dooriya
reviewed
Apr 23, 2023
swatDong
approved these changes
Apr 23, 2023
dooriya
approved these changes
Apr 23, 2023
This was referenced May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/17902085/
Updates in this PR:
IConversationReferenceStore.storeinNotificationBot.INotificationTargetStorageand the optionstorageinNotificationBot.GetPagedInstallationsAsync,GetPagedMembersAsync.GetMembersAsync.BuildTeamsBotInstallation.Incoming PR: