Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotehost should not be required when preauth_tunnel is being used #503

Closed
iliastsi opened this issue Oct 27, 2017 · 5 comments
Closed

Comments

@iliastsi
Copy link
Member

The latest version of OfflineIMAP now requires a remotehost even when preauthtunnel is being used. This is a regression from the previous version of OfflineIMAP (see also Debian bug #879705). The faulty commit seems to be 1ce596d. @drscream Could you please comment on why you replaced preauth_tunnel with transport_tunnel instead of taking both into account?

@nicolas33
Copy link
Member

nicolas33 commented Oct 27, 2017

I'll revert @drscream if the patch brings too much pain.

@iliastsi I'm thinking about to release a v7.1.4 due to the reported regressions of v7.1.3.

@drscream
Copy link
Contributor

drscream commented Oct 27, 2017

Dear @iliastsi and @nicolas33,

I'm really sorry that this fix break some other issue. I will need to have a look and may create a fix for the fix asap. But I hope I could also try to explain it a little bit better:

From my understanding preauth_tunnel is used to authenticate at any host and connect to the hostname which is required. The transport_tunnel is an replacement for the hostname because that command is executed to provide an IMAP interface.

But I could check it this weekend and get back to you!

@drscream
Copy link
Contributor

Additional to that it was totally my fault! I checked the code again and you're right we need to modify the code as below because both tunnels provides a regular IMAP interface at the end!

self.hostname = None if self.transport_tunnel or self.preauth_tunnel else repos.gethost()

drscream added a commit to drscream/offlineimap that referenced this issue Oct 27, 2017
…) the hostname should not be required

It's required to modify my change 1ce596d because a hostname shouldn't be needed if any tunnel is used. Both tunnels provide a regular IMAP interface which is used by offlineimap.

Signed-off-by: Thomas Merkel <tm@core.io>
nicolas33 pushed a commit that referenced this issue Oct 27, 2017
…should not be required

It's required to modify my change 1ce596d
because a hostname shouldn't be needed if any tunnel is used. Both tunnels
provide a regular IMAP interface which is used by offlineimap.

Github-ref: #503
Reported-by: Ilias Tsitsimpis <i.tsitsimpis@gmail.com>
Signed-off-by: Thomas Merkel <tm@core.io>
Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
@nicolas33
Copy link
Member

Thank you very much for the quick fix!
Applied.

@iliastsi
Copy link
Member Author

iliastsi commented Oct 27, 2017 via email

michaelcoyote pushed a commit to michaelcoyote/offlineimap that referenced this issue Jan 15, 2018
…should not be required

It's required to modify my change 1ce596d
because a hostname shouldn't be needed if any tunnel is used. Both tunnels
provide a regular IMAP interface which is used by offlineimap.

Github-ref: OfflineIMAP#503
Reported-by: Ilias Tsitsimpis <i.tsitsimpis@gmail.com>
Signed-off-by: Thomas Merkel <tm@core.io>
Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants