-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remotehost should not be required when preauth_tunnel is being used #503
Comments
Dear @iliastsi and @nicolas33, I'm really sorry that this fix break some other issue. I will need to have a look and may create a fix for the fix asap. But I hope I could also try to explain it a little bit better: From my understanding But I could check it this weekend and get back to you! |
Additional to that it was totally my fault! I checked the code again and you're right we need to modify the code as below because both tunnels provides a regular IMAP interface at the end!
|
…) the hostname should not be required It's required to modify my change 1ce596d because a hostname shouldn't be needed if any tunnel is used. Both tunnels provide a regular IMAP interface which is used by offlineimap. Signed-off-by: Thomas Merkel <tm@core.io>
…should not be required It's required to modify my change 1ce596d because a hostname shouldn't be needed if any tunnel is used. Both tunnels provide a regular IMAP interface which is used by offlineimap. Github-ref: #503 Reported-by: Ilias Tsitsimpis <i.tsitsimpis@gmail.com> Signed-off-by: Thomas Merkel <tm@core.io> Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
Thank you very much for the quick fix! |
…should not be required It's required to modify my change 1ce596d because a hostname shouldn't be needed if any tunnel is used. Both tunnels provide a regular IMAP interface which is used by offlineimap. Github-ref: OfflineIMAP#503 Reported-by: Ilias Tsitsimpis <i.tsitsimpis@gmail.com> Signed-off-by: Thomas Merkel <tm@core.io> Signed-off-by: Nicolas Sebrecht <nicolas.s-dev@laposte.net>
The latest version of OfflineIMAP now requires a remotehost even when preauthtunnel is being used. This is a regression from the previous version of OfflineIMAP (see also Debian bug #879705). The faulty commit seems to be 1ce596d. @drscream Could you please comment on why you replaced preauth_tunnel with transport_tunnel instead of taking both into account?
The text was updated successfully, but these errors were encountered: