Fix unbounded recursion in IMAPFolder #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing message flags, we were recursing once per 100 messages.
This causes RuntimeError("maximum recursion depth ...") when there are a
lot of messages in a folder that need to be updated. Instead of
recursing, iterate as the XXX comment suggests.
konvpalto
added a commit
that referenced
this pull request
Jul 8, 2014
We can do a simpler and more stack-friendly hack for IMAP servers with limited line lenghts. Reported-by: Josh Berry, https://github.com/josh-berry GH: #100 Signed-off-by: Eygene Ryabinkin <rea@codelabs.ru>
|
Pushed to "next" commit 1f2e8af that is a bit more radical rework: it completely eliminates recursion. Please, test. |
|
Checking now. |
|
Seems to work well for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing message flags, we were recursing once per 100 messages.
This causes RuntimeError("maximum recursion depth ...") when there are a
lot of messages in a folder that need to be updated. Instead of
recursing, iterate as the XXX comment suggests.