Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of LogRecord's msg attribute #118

Closed
wants to merge 1 commit into from
Closed

Correct spelling of LogRecord's msg attribute #118

wants to merge 1 commit into from

Conversation

jamessan
Copy link

No description provided.

Signed-off-by: James McCoy <vega.james@gmail.com>
@konvpalto
Copy link
Member

If will also require you to modify the 'extra' dictionary that is passed to self.logger.info() inside _printData to substitute 'mesg' for 'msg' there. So, the existing code looks consistent from the naming point of view.

What problem you're trying to solve?

@jamessan
Copy link
Author

Just noticed that there's an existing PR (#64) which provides a description of the problem and the same fix. I'll close mine.

@jamessan jamessan closed this Sep 30, 2014
konvpalto added a commit that referenced this pull request Oct 5, 2014
Old code were trying to pass the message to be output as-is,
but it should really be passed as the 'mesg' key in order to
be properly processed by MAchineLogFormatter.format().

GitHub pull: #64
GitHub pull: #118
Signed-off-by: Eygene Ryabinkin <rea@codelabs.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants