Fix uploading binary attachments to IMAP. #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfflineIMAP can try and upload binary data to the server if it thinks it has to. It should better mark its literals as binary per RFC 3516 if the server advertises it.
|
This is imaplib2 library change. We don't diverge from upstream, so it should be sent to Piers. See http://sourceforge.net/projects/imaplib2. Thanks! |
|
I'm closing since it's really about imaplib2 project. |
|
submitted at https://sourceforge.net/p/imaplib2/bugs/10/ |
|
Applied upstream changes. Thank you! |
|
This patch looked to be doing more harm than good in OfflineIMAP. Hence, Piers removed this change. According to him, the RFC is incorrectly implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OfflineIMAP can try and upload binary data to the server if it thinks it
has to. It should better mark its literals as binary per RFC 3516 if the
server advertises it.
Can probably be backported in the other branches.