-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Re-enable getprocesses, overlay, and keyboard watcher. #29
Linux: Re-enable getprocesses, overlay, and keyboard watcher. #29
Conversation
fab8f3d
to
8774d34
Compare
<3 |
8774d34
to
7ff8509
Compare
The overlay does work on Linux, but with some quirks (mainly on tiling window managers). Luckly the user can disable the overlay if they wish. My fork of memoryjs does support getProcesses, so I've re-enabled that code. I also have a linux port of 'node-keyboard-watcher' which I'd like to optimize, so that it can be put into a pull-request.
7ff8509
to
96578f7
Compare
This will allow the overlay to have transparency on Linux.
I just added the fixes for getting the overlay to render properly. |
Still doesn't work properly, because of electron not applying transparent visuals by default. EDIT: the interface also crashes on some clickable elements with this error (doesn't happen on @TheGreatMcPain electron-overlay-window fork, only @OhMyGuus merged one):
|
That's because I haven't updated this pull-request with the most recent changes to OhMyGuus's fork of Also when you say, "doesn't work properly", is the overlay not transparent, because it's transparent on my end. |
It is fully white on my side, until I enable this --enable-transparent-visuals option. Howewer on my laptop I only have iGPU, no GPU, which could explain this difference |
Okay, I will try it on my laptop which has an ivybridge intel iGPU. |
Finally found time to make the Linux version fully happen +1, I remade the branch since it had a lot of stuff that wasn't needed like you mentioned and moved it to a temp fork so I can test the installation process before it gets fully merged to the main repo. |
The overlay does work on Linux, but with some quirks (mainly on tiling window managers).
I still need to add the Linux specific fixes for the overlay, which consist of disabling hardware acceleration and adding a timeout during window creation..
Luckily the user can fully disable the overlay if they wish via BetterCrewLink's settings. (unlike the original version of CrewLink)
My fork of memoryjs does support getProcesses, so I've re-enabled that code too.
I also have a linux port of node-keyboard-watcher which works, but it's not cross-platform friendly yet.