This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Add getSize() to MotorGroup #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #472 +/- ##
===========================================
+ Coverage 88.63% 88.87% +0.24%
===========================================
Files 139 139
Lines 5841 5841
===========================================
+ Hits 5177 5191 +14
+ Misses 664 650 -14 |
Octogonapus
added a commit
that referenced
this pull request
May 23, 2022
* Switch from Pathfinder to Squiggles for path generation (#461) * add squiggles as a cmake dependency * building * tests passing again * tests are passing * remove pathfinder and switch to squiggles in lmpc * i think i fixed the PROS build * Various CI fixes well i was wrong but this should work squiggles version back to c++17 this is a hack but it seems to work trying to remove the cmake build step since this is working on my machine... i guess rsync isn't included with github actions container remove the use of rsync forgot to undo the installation of rsync cmake-build-debug already exists at that step fix valgrind errors * resolving the minor review comments * resolve review comments * Resolve review comments for tests need to bump g++ version to get filesystem header trying to get gcc9 switch to using C functions for filesystem interaction revert the CI script * pin squiggles version at 1.0.0 * copy the squiggles headers into the templates' inc dir too * on second thought, better to have squiggles inside okapi dir * resolve the issue with the executeSinglePath delay * invert the Y axis for the squiggles generation to match with ROS coords * fix the frame transformation and tests * squiggles to 1.1.0 * update squiggles again to fix tests * Fix segfault due to undefined use of front() * ensure that the PROS build uses the latest squiggles files * Adjust motion profiling documentation to mention Squiggles instead of Pathfinder. * fix issue where build fails when squiggles doesn't yet exist * Fix tutorials to use "wheel track" instead of "wheelbase" (#469) Co-authored-by: Octogonapus <firey45@gmail.com> Co-authored-by: Shawn Phelps <30736878+shawnphelps@users.noreply.github.com> * Add getSize() to MotorGroup (#472) * Fix tutorials to use "wheel track" instead of "wheelbase" (#469) * Add getSize() to MotorGroup Co-authored-by: Shawn Phelps <30736878+shawnphelps@users.noreply.github.com> Co-authored-by: Octogonapus <firey45@gmail.com> * Version bump * Add tile unit to docs Co-authored-by: Jonathan Bayless <16109996+baylessj@users.noreply.github.com> Co-authored-by: Shawn Phelps <30736878+shawnphelps@users.noreply.github.com> Co-authored-by: Brendan McGuire <brendan@bren.app>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds
getSize()toMotorGroup, which returns the number of motors based on the internal vector.Motivation
There currently is no way to get this information.
Possible Drawbacks
Increased API surface, but in this case, it's relatively minor.
Verification Process
Directly returning internal information. It doesn't seem like MotorGroup has associated tests, but I can add tests if I'm missing them
Future Work
It may be worth implementing Iterator for the MotorGroup; most situations that would require getting the number of motors involve iterating through the motors.