Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare link is down #118

Closed
joseph-allen opened this issue Mar 17, 2020 · 6 comments
Closed

Cloudflare link is down #118

joseph-allen opened this issue Mar 17, 2020 · 6 comments

Comments

@joseph-allen
Copy link
Contributor

Using the Cloudflare link responds with a 404, not sure if this is just for me so if somebody else can confirm?

Needs to be either removed from docs or put back on cloudflare!

@Okazari
Copy link
Owner

Okazari commented Mar 17, 2020

Hey @joseph-allen, this links work fine for me : https://cdnjs.cloudflare.com/ajax/libs/rythm.js/2.2.5/rythm.min.js

Maybe it was unclear that you must replace 2.x.x with the version you want for your project. If so, you can make a PR to improve the doc in this direction 😉

@joseph-allen
Copy link
Contributor Author

Should we replace the x's with the latest release, or keep as is? plus a note that it needs to be replaced by the user?

@Okazari
Copy link
Owner

Okazari commented Mar 17, 2020

I think it may be smarter to replace the x's with the latest release. Do you want to add your contribution to the project through this ? 😄

@joseph-allen
Copy link
Contributor Author

yeah I will do it :D

@joseph-allen
Copy link
Contributor Author

joseph-allen commented Mar 17, 2020

༼ つ ◕_◕ ༽つ PR

@Okazari
Copy link
Owner

Okazari commented Mar 17, 2020

Thanks ! And welcome as a contributor 😄

@Okazari Okazari closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants