-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on Safari / Chrome (MacOS) #7
Comments
You can add |
I probably need to add a polyfill for safari. I will look how i can do this in a clean way. It will also fix #4 thought. |
Just found this : I'll go for this fix. |
I just updated the code and the demo, @hiro28 could you try it again on Safari ? If this works, i'll release a v1.2.4 with this patch. |
Someone reported that it didn't work in chrome on Mac too 😱 |
I'm currently debugging your code, since I want this proejct working on mobile phone. Line 167 : However, the animations don't work properly. After some research, the main cause is on the analyser itself, but I didn't know the exact cause for the moment. EDIT : After some research, I found this example which use Audio API When testing on Safari, it reveal that the function getByteFrequencyData always return an entire array of 0. |
Hey @Nouvan Thanks for the feedback ! The current code is already using this correction https://github.com/Okazari/Rythm.js/blob/master/src/Player.js#L5 It looks like safari will need a polyfill for this functionnality, i'll look in this way. |
Hi @Okazari ! Did you try https://github.com/mohayonao/web-audio-engine ? Maybe it would be enough to make your project good on IOS devices ;) ! I will try soon and send you the results of my test. |
Thanks @Nouvan i appreciate. I actually cannot work on Rythm.js because i got a lot of works and projects to finalize ! Anyway, thanks for the suggestion, i'll take a look. Still need to test if polyfills would be enougth tho. |
throwaway12933428233 on reddit : |
Here is the console's log
The text was updated successfully, but these errors were encountered: