Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picture plugin #176

Merged
merged 5 commits into from
Apr 7, 2024
Merged

picture plugin #176

merged 5 commits into from
Apr 7, 2024

Conversation

slayernominee
Copy link
Contributor

addressing #52

Bildschirmfoto 2024-04-03 um 21 22 51

the preview image (deer) is locally added.

the image can be set via an url setting
Bildschirmfoto 2024-04-03 um 21 44 05

@slayernominee
Copy link
Contributor Author

the deer is btw from unsplash

Copy link
Owner

@OlegWock OlegWock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR, I added couple of comments

src/plugins/picture/picture-plugin.tsx Outdated Show resolved Hide resolved
src/plugins/picture/picture-plugin.tsx Outdated Show resolved Hide resolved
src/plugins/picture/picture-plugin.tsx Outdated Show resolved Hide resolved
src/plugins/picture/picture-plugin.tsx Outdated Show resolved Hide resolved
src/plugins/picture/picture-plugin.tsx Outdated Show resolved Hide resolved
src/plugins/picture/picture-plugin.tsx Show resolved Hide resolved
@slayernominee
Copy link
Contributor Author

i see one problem with not using a placeholder image:
with no internet connection the mock will not have an image to show / shows the alt text
respectively with a slow internet connection it shows nothing at first

possible solutions for this would be if we either use a placeholder image (or maybe even some random selected one from a multiple intern images) or some css animation ig

@OlegWock
Copy link
Owner

OlegWock commented Apr 6, 2024

That's true, but I think it will be a rare occurrence. Anori is browser extension, so user probably will have internet connection while using it anyway. And even if they don't, picture widgets in folder won't work without internet anyway, so I don't think we need 'special treatment' for mock (which user will see a lot less often)

@slayernominee
Copy link
Contributor Author

removed it

@OlegWock
Copy link
Owner

OlegWock commented Apr 7, 2024

Thanks :)

@OlegWock OlegWock merged commit 130dda5 into OlegWock:master Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants