-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picture plugin #176
picture plugin #176
Conversation
the deer is btw from unsplash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thanks for the PR, I added couple of comments
i see one problem with not using a placeholder image: possible solutions for this would be if we either use a placeholder image (or maybe even some random selected one from a multiple intern images) or some css animation ig |
That's true, but I think it will be a rare occurrence. Anori is browser extension, so user probably will have internet connection while using it anyway. And even if they don't, picture widgets in folder won't work without internet anyway, so I don't think we need 'special treatment' for mock (which user will see a lot less often) |
removed it |
Thanks :) |
addressing #52
the preview image (deer) is locally added.
the image can be set via an url setting