Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse spaces #40

Merged
merged 3 commits into from Sep 5, 2019
Merged

Collapse spaces #40

merged 3 commits into from Sep 5, 2019

Conversation

jordandh
Copy link

Adds a collapseSpaces option which changes how text and comment nodes are compared for equality by collapsing all the white space in them first.

Jordan Harrison added 2 commits August 28, 2019 11:35
…s are compared for equality by collapsing all the white space in them first.
…characters with a space character.

Added collapseSpaces support to node value comparison.
@jordandh jordandh marked this pull request as ready for review August 28, 2019 21:56
@coveralls
Copy link

coveralls commented Aug 28, 2019

Coverage Status

Coverage decreased (-0.5%) to 91.353% when pulling 5dd006f on madcapsoftware:collapse-spaces into 1b57676 on Olegas:master.

@Olegas
Copy link
Owner

Olegas commented Aug 30, 2019

Hi @jordandh ! Thank for your contribution!
Could you please add some tests for this new option?

@Olegas Olegas merged commit 5071578 into Olegas:master Sep 5, 2019
@Olegas
Copy link
Owner

Olegas commented Sep 5, 2019

@jordandh Thank you! Will publish as 0.4.0 in a minute!

@jordandh
Copy link
Author

jordandh commented Sep 5, 2019

No problem. Thanks for merging it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants