Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing version strings lexicographically may fail (e.g. 3.0.3.9 -> 3.0.3.10) #24

Closed
Olf0 opened this issue May 31, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@Olf0
Copy link
Owner

commented May 31, 2019

Comparing SailfishOS version strings lexicographically may fail, if a version field is a single digit in one version string and double digit in the other strings.
Hence, e.g. 3.0.3.9 -> 3.0.3.10 is incorrectly determined to be a downgrade (as described in the original report).

@Olf0 Olf0 added the bug label May 31, 2019

@Olf0 Olf0 self-assigned this May 31, 2019

@Olf0 Olf0 added usability and removed bug labels May 31, 2019

@Olf0

This comment has been minimized.

Copy link
Owner Author

commented Jun 1, 2019

Fixed in PR #25.

@Olf0

This comment has been minimized.

Copy link
Owner Author

commented Jun 2, 2019

A release with this fix was published as sfos-upgrade 3.0.

@Olf0 Olf0 closed this Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.