Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparing version strings lexicographically may fail (e.g. 3.0.3.9 -> 3.0.3.10) #24

Closed
Olf0 opened this issue May 31, 2019 · 2 comments
Closed

Comparing version strings lexicographically may fail (e.g. 3.0.3.9 -> 3.0.3.10) #24

Olf0 opened this issue May 31, 2019 · 2 comments
Assignees
@Olf0
Labels
fixed Already fixed in SCM usability Usability nuisances

Comments

@Olf0
Copy link
Owner

Olf0 commented May 31, 2019 •
edited
Loading

Comparing SailfishOS version strings lexicographically may fail, if a version field is a single digit in one version string and double digit in the other strings.
Hence, e.g. 3.0.3.9 -> 3.0.3.10 is incorrectly determined to be a downgrade (as described in the original report).
@Olf0 Olf0 added the bug Something isn't working label May 31, 2019
@Olf0 Olf0 self-assigned this May 31, 2019
@Olf0 Olf0 added usability Usability nuisances and removed bug Something isn't working labels May 31, 2019
@Olf0 Olf0 mentioned this issue Jun 1, 2019
Merged
@Olf0
Copy link
Owner Author

Olf0 commented Jun 1, 2019 •
edited
Loading

Fixed in PR #25.

@Olf0
Copy link
Owner Author

Olf0 commented Jun 2, 2019

A release with this fix was published as sfos-upgrade 3.0.

@Olf0 Olf0 closed this as completed Jun 2, 2019
@Olf0 Olf0 added the fixed Already fixed in SCM label Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Olf0 Olf0

Labels
fixed Already fixed in SCM usability Usability nuisances
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Olf0